Simplify example app by removing Docker and web dashboard#172
Closed
sueszli wants to merge 9 commits intopiercefreeman:mainfrom
Closed
Simplify example app by removing Docker and web dashboard#172sueszli wants to merge 9 commits intopiercefreeman:mainfrom
sueszli wants to merge 9 commits intopiercefreeman:mainfrom
Conversation
Contributor
Author
|
The behavior is the same and not impacted. |
Owner
|
@sueszli There's some value in the more complete example app, because it shows users how they'll actually integrate waymark with a serving pipeline. But agreed that the current scope is overkill. We can pair it down to a single workflow just to show the request/response/delegation logic within Docker. Can you refactor what you have here into a new example-workflow folder (so we'll have example_app and example_workflows)... This example-workflows could also use a very basic README with run instructions. |
piercefreeman
added a commit
that referenced
this pull request
Mar 1, 2026
This PR sits on top of #172 - and it also starts a chain of PRs that will be pointing to each other's branch to simplify the review. <img width="642" height="86" alt="image" src="https://github.com/user-attachments/assets/a56694d2-37e2-4569-a744-780ab863079f" /> Here it says "into `main`" - this is right, when the PR says something in the likes of "into `bump-thiserror`" - that means we're not ready to merge it, and we need to merge previous ones first. Github has quite poor support for chaining PRs - but this works for the most part, just need to be careful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example app had grown too complex with Docker orchestration, a full web dashboard UI and multi-stage builds. This made it harder for new users to understand the core Waymark functionality. By stripping it down to the essentials, the example now clearly demonstrates workflow patterns without infrastructure complexity.
Changes
Impact